Skip to content

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Sep 10, 2025

Issue number: internal


What is the new behavior?

This pull request updates the color and background variables across many Ionic component styles to use new design system tokens, improving consistency and maintainability. It also temporarily skips several visual regression tests for the datetime component due to a known issue (FW-6769).

Design System Token Migration:

  • Updated --color and --background variables in many components (e.g., card, card-title, list-header, item, segment, radio, select, textarea, input, checkbox, chip, datetime, item-options, searchbar) to use the new globals.$ion-text-default and globals.$ion-bg-surface-default tokens instead of older primitives. This change ensures consistent theming and easier future maintenance. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]

Test Suite Maintenance:

  • Temporarily skipped several E2E visual regression tests for datetime and item components, referencing TODO FW-6769, to prevent test failures while an upstream issue is addressed. [1] [2] [3] [4] [5]

There're some snapshots updates that seem to have no visible differences, so I would say its ok to accept the new ones.

Does this introduce a breaking change?

  • Yes
  • No

@BenOsodrac BenOsodrac added the type: bug a confirmed bug report label Sep 10, 2025
@vercel
Copy link

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Sep 22, 2025 3:52pm

@BenOsodrac BenOsodrac requested a review from ShaneK September 11, 2025 09:24
@BenOsodrac BenOsodrac marked this pull request as ready for review September 11, 2025 09:26
@BenOsodrac BenOsodrac requested a review from a team as a code owner September 11, 2025 09:26
@ShaneK ShaneK changed the title feat(tokens): update tokens usage to reflect UI arquictecture feat(tokens): update tokens usage to reflect UI architecture Sep 17, 2025
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions here clarifying the variables being used, but it looks good overall! 🚀

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small suggestion to tie in with the global theming but since this will likely be re-worked with the modular work it is not a blocker. 👍

@BenOsodrac BenOsodrac merged commit 0a3c7d6 into next Sep 23, 2025
50 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11901-v2 branch September 23, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants